netdev - Re: [PATCH] sh_eth: fix descriptor access endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151215.125336.1876941788722356501.davem@davemloft.net>
Date:	Tue, 15 Dec 2015 12:53:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: fix descriptor access endianness

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Tue, 15 Dec 2015 14:26:51 +0300

> Hello.
> 
> On 12/15/2015 8:25 AM, David Miller wrote:
> 
>>> The driver never calls cpu_to_edmac() when writing the descriptor
>>> address
>>> and edmac_to_cpu() when reading it, although it should -- fix this.
>>>
>>> Note that the frame/buffer length descriptor field accesses also need
>>> fixing
>>> but since they are both 16-bit we can't use
>>> {cpu|edmac}_to_{edmac|cpu}()...
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>> Applied.
> 
>    I was going to rework this to fix _all_ cases, and sent follow-up
>    email about that yesterday... Haven't you received it?

I saw it but you were not entirely clear whether you were going to do
that work in a follow-on patch or not.

If you don't clearly say "Dave, please drop this patch." expect me to
do random things.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html