netdev - Re: [PATCH net] net_sched: make qdisc_tree_decrease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151215.134233.1041810878194617389.davem@davemloft.net>
Date:	Tue, 15 Dec 2015 13:42:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, stasn77@...il.com
Subject: Re: [PATCH net] net_sched: make qdisc_tree_decrease_qlen() work
 for non mq

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 15 Dec 2015 09:43:12 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Stas Nichiporovich reported a regression in his HFSC qdisc setup
> on a non multi queue device.
> 
> It turns out I mistakenly added a TCQ_F_NOPARENT flag on all qdisc
> allocated in qdisc_create() for non multi queue devices, which was
> rather buggy. I was clearly mislead by the TCQ_F_ONETXQUEUE that is
> also set here for no good reason, since it only matters for the root
> qdisc.
> 
> Fixes: 4eaf3b84f288 ("net_sched: fix qdisc_tree_decrease_qlen() races")
> Reported-by: Stas Nichiporovich <stasn77@...il.com>
> Tested-by: Stas Nichiporovich <stasn77@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html