netdev - Re: [PATCH] net: add Qualcomm IPC router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450214050.4464.10.camel@redhat.com>
Date:	Tue, 15 Dec 2015 15:14:10 -0600
From:	Dan Williams <dcbw@...hat.com>
To:	David Miller <davem@...emloft.net>, bjorn.andersson@...ymobile.com
Cc:	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	netdev@...r.kernel.org, srinivas.kandagatla@...aro.org,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, courtney.cavin@...ymobile.com
Subject: Re: [PATCH] net: add Qualcomm IPC router

On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:
> On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:
> > From: Bjorn Andersson <bjorn.andersson@...ymobile.com>
> > Date: Fri, 11 Dec 2015 12:41:59 -0800
> > 
> > > +static unsigned int qrtr_local_nid = 1;
> > > +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> > > +MODULE_PARM_DESC(idVendor, "Local Node Identifier");
> 
> Also s/idVendor/node_id?

Well, not that it matters if the module parameter gets removed...

Dan

> 
> Dan
> 
> > Module parameters suck.
> > 
> > Allow the user to choose this dynamically.  You have roughtly two
> > choices.
> > 
> > 1) Subvert the 'protocol' field passed to ->create() and use that,
> > it
> > is
> >    being ignored otherwise.
> > 
> > 2) Put it into the socket address for bind().
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev"
> > in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html