netdev - Re: [PATCH net-next 0/8] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151215.163233.1822498299187427740.davem@davemloft.net>
Date:	Tue, 15 Dec 2015 16:32:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next 0/8] net: The beginning of the end for
 NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM

From: Tom Herbert <tom@...bertland.com>
Date: Mon, 14 Dec 2015 11:19:39 -0800

> This patch set starts to address one front in the battle against
> protocol ossification.

Looks good series applied, thanks.

Two things:

1) I'd ask you to reconsider passing that struct with the bit fields into
   the chk routines.  Some cpu ABIs pass that thing as an aggregate on
   the stack.  Whereas if you just use a simple bit mask and BIT(x) values
   we know it's always going to be passed in as an integer or whatever.

2) As per the TCP check, it is definitely more strict now.  But I seriously
   doubt get ever gained anything real with the previous, looser, check.
   Besides, if it bites a user segment we will get a report and can adjust
   things.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html