netdev - Re: [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2015 08:06:58 +0100
From:	Florian Westphal <fw@...len.de>
To:	Tom Herbert <tom@...bertland.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v5 net-next 4/4] ila: Add generic ILA translation facility

Tom Herbert <tom@...bertland.com> wrote:
> +static int ila_add_mapping(struct net *net, struct ila_xlat_params *p)
> +{
> +	struct ila_net *ilan = net_generic(net, ila_net_id);
> +	struct ila_map *ila, *head;
> +	spinlock_t *lock = ila_get_lock(ilan, p->identifier);
> +	int err = 0, order;
> +
> +	if (!ilan->hooks_registered) {
> +		/* We defer registering net hooks in the namespace until the
> +		 * first mapping is added.
> +		 */
> +		err = nf_register_net_hooks(net, ila_nf_hook_ops,
> +					    ARRAY_SIZE(ila_nf_hook_ops));
> +		if (err)
> +			return err;

Looks as if this misses a
		ilan->hooks_registered = true
> +	}
> +
> +	ila = kzalloc(sizeof(*ila), GFP_KERNEL);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html