netdev - Re: [PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2015 16:19:24 +0800
From:	Stefan Hajnoczi <stefanha@...hat.com>
To:	Alex Bennée <alex.bennee@...aro.org>
Cc:	kvm@...r.kernel.org, Matt Benjamin <mbenjamin@...hat.com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>,
	matt.ma@...aro.org, virtualization@...ts.linux-foundation.org,
	Asias He <asias@...hat.com>
Subject: Re: [PATCH v3 4/4] VSOCK: Add Makefile and Kconfig

On Fri, Dec 11, 2015 at 05:19:08PM +0000, Alex Bennée wrote:
> > +config VHOST_VSOCK
> > +	tristate "vhost virtio-vsock driver"
> > +	depends on VSOCKETS && EVENTFD
> > +	select VIRTIO_VSOCKETS_COMMON
> > +	select VHOST
> > +	select VHOST_RING
> > +	default n
> > +	---help---
> > +	Say M here to enable the vhost-vsock for virtio-vsock guests
> 
> I think checkpatch prefers a few more words for the feature but I'm
> happy with it.

I have expanded the description.

> > diff --git a/net/vmw_vsock/Kconfig b/net/vmw_vsock/Kconfig
> > index 14810ab..74e0bc8 100644
> > --- a/net/vmw_vsock/Kconfig
> > +++ b/net/vmw_vsock/Kconfig
> > @@ -26,3 +26,21 @@ config VMWARE_VMCI_VSOCKETS
> >
> >  	  To compile this driver as a module, choose M here: the module
> >  	  will be called vmw_vsock_vmci_transport. If unsure, say N.
> > +
> > +config VIRTIO_VSOCKETS
> > +	tristate "virtio transport for Virtual Sockets"
> > +	depends on VSOCKETS && VIRTIO
> > +	select VIRTIO_VSOCKETS_COMMON
> > +	help
> > +	  This module implements a virtio transport for Virtual Sockets.
> > +
> > +	  Enable this transport if your Virtual Machine runs on
> >  	  Qemu/KVM.
> 
> Is this better worded as:
> 
> "Enable this transport if your Virtual Machine host supports vsockets
> over virtio."

Good idea.  Will fix in the next revision.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)