netdev - RE: [PATCH bluetooth-next] 6lowpan: fix debugfs interface entry name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AB80DA35A7B64E4E98291794926897D9011B97549F@MBX03.nvlsi.no>
Date:	Tue, 15 Dec 2015 11:47:27 +0000
From:	"Duda, Lukasz" <Lukasz.Duda@...dicsemi.no>
To:	Alexander Aring <alex.aring@...il.com>,
	"linux-wpan@...r.kernel.org" <linux-wpan@...r.kernel.org>
CC:	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH bluetooth-next] 6lowpan: fix debugfs interface entry name

Hi Alex,

> -----Original Message-----
> From: Alexander Aring [mailto:alex.aring@...il.com]
> Sent: Tuesday, December 15, 2015 12:26
> To: linux-wpan@...r.kernel.org
> Cc: linux-bluetooth@...r.kernel.org; netdev@...r.kernel.org;
> kernel@...gutronix.de; Duda, Lukasz; Alexander Aring
> Subject: [PATCH bluetooth-next] 6lowpan: fix debugfs interface entry name
> 
> This patches moves the debugfs interface related register after netdevice
> register. The function lowpan_dev_debugfs_init will use "dev->name" which
> can be before register_netdevice a format string.
> The function register_netdevice will evaluate the format string if necessary
> and replace "dev->name" to the real interface name.
> 
> Reported-by: Lukasz Duda <lukasz.duda@...dicsemi.no>
> Signed-off-by: Alexander Aring <alex.aring@...il.com>
> ---
>  net/6lowpan/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c index c7f06f5..faf65ba
> 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -29,13 +29,13 @@ int lowpan_register_netdevice(struct net_device
> *dev,
> 
>  	lowpan_priv(dev)->lltype = lltype;
> 
> -	ret = lowpan_dev_debugfs_init(dev);
> +	ret = register_netdevice(dev);
>  	if (ret < 0)
>  		return ret;
> 
> -	ret = register_netdevice(dev);
> +	ret = lowpan_dev_debugfs_init(dev);
>  	if (ret < 0)
> -		lowpan_dev_debugfs_exit(dev);
> +		unregister_netdevice(dev);
> 
>  	return ret;
>  }
> --
> 2.6.1

Thanks, after this change I do have correct interface name under
/sys/kernel/debug/6lowpan for Bluetooth Low Energy (bt0).

Acked-by: Lukasz Duda <lukasz.duda@...dicsemi.no>

Best regards,
Łukasz

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html