netdev - Re: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56702A68.8000600@6wind.com>
Date:	Tue, 15 Dec 2015 15:57:44 +0100
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Vladislav Yasevich <vyasevich@...il.com>, netdev@...r.kernel.org
Cc:	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header

Le 14/12/2015 23:44, Vladislav Yasevich a écrit :
> skb_reorder_vlan_header is called after the vlan header has
> been pulled.  As a result the offset of the begining of
> the mac header has been incrased by 4 bytes (VLAN_HLEN).
> When moving the mac addresses, include this incrase in
> the offset calcualation so that the mac addresses are
> copied correctly.
>
> Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off)
> CC: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> CC: Patrick McHardy <kaber@...sh.net>
> Signed-off-by: Vladislav Yasevich <vyasevich@...il.com>
Thank you for the fix. A bit late, but for the record:

Tested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html