netdev - Re: [PATCH net] tcp: restore fastopen with no data in SYN packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2015 15:02:02 -0800
From:	Yuchung Cheng <ycheng@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH net] tcp: restore fastopen with no data in SYN packet

On Wed, Dec 16, 2015 at 1:53 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> Yuchung tracked a regression caused by commit 57be5bdad759 ("ip: convert
> tcp_sendmsg() to iov_iter primitives") for TCP Fast Open.
>
> Some Fast Open users do not actually add any data in the SYN packet.
>
> Fixes: 57be5bdad759 ("ip: convert tcp_sendmsg() to iov_iter primitives")
> Reported-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> ---
Acked-by: Yuchung Cheng <ycheng@...gle.com>
>  net/ipv4/tcp_output.c |   23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index cb7ca569052c..9bfc39ff2285 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -3150,7 +3150,7 @@ static int tcp_send_syn_data(struct sock *sk, struct sk_buff *syn)
>  {
>         struct tcp_sock *tp = tcp_sk(sk);
>         struct tcp_fastopen_request *fo = tp->fastopen_req;
> -       int syn_loss = 0, space, err = 0, copied;
> +       int syn_loss = 0, space, err = 0;
>         unsigned long last_syn_loss = 0;
>         struct sk_buff *syn_data;
>
> @@ -3188,17 +3188,18 @@ static int tcp_send_syn_data(struct sock *sk, struct sk_buff *syn)
>                 goto fallback;
>         syn_data->ip_summed = CHECKSUM_PARTIAL;
>         memcpy(syn_data->cb, syn->cb, sizeof(syn->cb));
> -       copied = copy_from_iter(skb_put(syn_data, space), space,
> -                               &fo->data->msg_iter);
> -       if (unlikely(!copied)) {
> -               kfree_skb(syn_data);
> -               goto fallback;
> -       }
> -       if (copied != space) {
> -               skb_trim(syn_data, copied);
> -               space = copied;
> +       if (space) {
> +               int copied = copy_from_iter(skb_put(syn_data, space), space,
> +                                           &fo->data->msg_iter);
> +               if (unlikely(!copied)) {
> +                       kfree_skb(syn_data);
> +                       goto fallback;
> +               }
> +               if (copied != space) {
> +                       skb_trim(syn_data, copied);
> +                       space = copied;
> +               }
>         }
> -
>         /* No more data pending in inet_wait_for_connect() */
>         if (space == fo->size)
>                 fo->data = NULL;
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html