netdev - Re: [PATCH] gianfar: Don't enable RX Filer if not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151216.183155.1166436702361116871.davem@davemloft.net>
Date:	Wed, 16 Dec 2015 18:31:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	hamish.martin@...iedtelesis.co.nz, netdev@...r.kernel.org
Subject: Re: [PATCH] gianfar: Don't enable RX Filer if not supported

From: Manoil Claudiu <claudiu.manoil@...escale.com>
Date: Tue, 15 Dec 2015 10:12:36 +0000

>>-----Original Message-----
>>From: Hamish Martin [mailto:hamish.martin@...iedtelesis.co.nz]
>>Sent: Tuesday, December 15, 2015 3:15 AM
>>To: Manoil Claudiu-B08782 <claudiu.manoil@...escale.com>
>>Cc: netdev@...r.kernel.org; Hamish Martin
>><hamish.martin@...iedtelesis.co.nz>
>>Subject: [PATCH] gianfar: Don't enable RX Filer if not supported
>>
>>After commit 15bf176db1fb ("gianfar: Don't enable the Filer w/o the
>>Parser"), 'TSEC' model controllers (for example as seen on MPC8541E)
>>always have 8 bytes stripped from the front of received frames.
>>Only 'eTSEC' gianfar controllers have the RX Filer capability (amongst
>>other enhancements). Previously this was treated as always enabled
>>for both 'TSEC' and 'eTSEC' controllers.
>>In commit 15bf176db1fb ("gianfar: Don't enable the Filer w/o the Parser")
>>a subtle change was made to the setting of 'uses_rxfcb' to effectively
>>always set it (since 'rx_filer_enable' was always true). This had the
>>side-effect of always stripping 8 bytes from the front of received frames
>>on 'TSEC' type controllers.
>>
>>We now only enable the RX Filer capability on controller types that
>>support it, thereby avoiding the issue for 'TSEC' type controllers.
>>
> 
> 
> Reviewed-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html