netdev - Re: [PATCH net] inet: tcp: fix inetpeer_set_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151216.001435.1872718804742060388.davem@davemloft.net>
Date:	Wed, 16 Dec 2015 00:14:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, dsa@...ulusnetworks.com, ycheng@...gle.com,
	ncardwell@...gle.com
Subject: Re: [PATCH net] inet: tcp: fix inetpeer_set_addr_v4()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 15 Dec 2015 20:56:44 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> David Ahern added a vif field in the a4 part of inetpeer_addr struct.
> 
> This broke IPv4 TCP fast open client side and more generally tcp metrics
> cache, because inetpeer_addr_cmp() is now comparing two u32 instead of
> one.
> 
> inetpeer_set_addr_v4() needs to properly init vif field, otherwise
> the comparison result depends on uninitialized data.
> 
> Fixes: 192132b9a034 ("net: Add support for VRFs to inetpeer cache")
> Reported-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html