netdev - Re: [PATCH] rhashtable: Always allocate at least one bucket lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151216055310.GA23634@gondor.apana.org.au>
Date:	Wed, 16 Dec 2015 13:53:10 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	William Hua <william.hua@...onical.com>
Cc:	netdev@...r.kernel.org, tgraf@...g.ch, william.hua@...onical.com
Subject: Re: [PATCH] rhashtable: Always allocate at least one bucket lock

William Hua <william.hua@...onical.com> wrote:
> No bucket locks are allocated when an rhashtable is initialized with
> fewer than two elements. In this special case, we should allocate at
> least one to prevent a segfault.
> 
> Signed-off-by: William Hua <william.hua@...onical.com>

Huh? The minimum hash table size is 4.  How are you getting an
rhashtable that's smaller than the required minimum?
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html