netdev - Re: [PATCH iproute2] ipv6: allow setting stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64C7B1E3-1F0C-4472-91A9-9D6DE5206D6A@mork.no>
Date:	Wed, 16 Dec 2015 17:56:55 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	netdev@...r.kernel.org
CC:	stephen@...workplumber.org
Subject: Re: [PATCH iproute2] ipv6: allow setting stable_secret mode



On December 16, 2015 12:30:08 PM CET, Hannes Frederic Sowa <hannes@...essinduktion.org> wrote:
>Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>---
> ip/iplink.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/ip/iplink.c b/ip/iplink.c
>index f30de86d1858a0..e824082f7d8149 100644
>--- a/ip/iplink.c
>+++ b/ip/iplink.c
>@@ -84,7 +84,7 @@ void iplink_usage(void)
> 	fprintf(stderr, "				   [ state { auto | enable | disable} ] ]\n");
> 	fprintf(stderr, "			  [ master DEVICE ]\n");
> 	fprintf(stderr, "			  [ nomaster ]\n");
>-	fprintf(stderr, "			  [ addrgenmode { eui64 | none } ]\n");
>+	fprintf(stderr, "			  [ addrgenmode { eui64 | none | stable_secret }
>]\n");
> 	fprintf(stderr, "	                  [ protodown { on | off } ]\n");
>	fprintf(stderr, "       ip link show [ DEVICE | group GROUP ] [up]
>[master DEV] [type TYPE]\n");
> 
>@@ -176,6 +176,8 @@ static int get_addr_gen_mode(const char *mode)
> 		return IN6_ADDR_GEN_MODE_EUI64;
> 	if (strcasecmp(mode, "none") == 0)
> 		return IN6_ADDR_GEN_MODE_NONE;
>+	if (strcasecmp(mode, "stable_secret") == 0)
>+		return IN6_ADDR_GEN_MODE_STABLE_PRIVACY;
> 	return -1;
> }
> 

Ah, didn't notice this before I sent my similar patch. Sorry about that.

But FWIW, I really don't like the renaming you do here. 
If the mode is 'stable_privacy', then it should be known
by that name here as well.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html