netdev - Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <907481450345533@web24h.yandex.ru>
Date:	Thu, 17 Dec 2015 12:45:33 +0300
From:	Dmitrii Shcherbakov <fw.dmitrii@...dex.com>
To:	Jesper Dangaard Brouer <brouer@...hat.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Phil Sutter <psutter@...hat.com>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device_name> ' command

Jesper,

Sorry, it seems that I accidentally sent out an unfinished e-mail.

>I don't think your patch should contain this cleanup of "b4".

It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead.

administrator@...ntu:~/src/iproute2/tc$ git rev-parse HEAD
654ae881de57467642c8c2ed16ffc3a8d57fafa2

administrator@...ntu:~/src/iproute2/tc$ grep -nHP -B 3 'b3' q_htb.c
q_htb.c-273-	__u64 rate64, ceil64;
q_htb.c-274-	SPRINT_BUF(b1);
q_htb.c-275-	SPRINT_BUF(b2);
q_htb.c:276:	SPRINT_BUF(b3);
--
q_htb.c-317-				sprint_size(buffer, b1),
q_htb.c-318-				1<<hopt->rate.cell_log,
q_htb.c-319-				sprint_size(hopt->rate.mpu&0xFF, b2),
q_htb.c:320:				sprint_size((hopt->rate.mpu>>8)&0xFF, b3));
--
q_htb.c-322-				sprint_size(cbuffer, b1),
q_htb.c-323-				1<<hopt->ceil.cell_log,
q_htb.c-324-				sprint_size(hopt->ceil.mpu&0xFF, b2),
q_htb.c:325:				sprint_size((hopt->ceil.mpu>>8)&0xFF, b3));
administrator@...ntu:~/src/iproute2/tc$ grep -nHP -B 3 'b4' q_htb.c
q_htb.c-274-	SPRINT_BUF(b1);
q_htb.c-275-	SPRINT_BUF(b2);
q_htb.c-276-	SPRINT_BUF(b3);
q_htb.c:277:	SPRINT_BUF(b4);
--
q_htb.c-311-		cbuffer = tc_calc_xmitsize(ceil64, hopt->cbuffer);
q_htb.c-312-		linklayer = (hopt->rate.linklayer & TC_LINKLAYER_MASK);
q_htb.c-313-		if (linklayer > TC_LINKLAYER_ETHERNET || show_details)
q_htb.c:314:			fprintf(f, "linklayer %s ", sprint_linklayer(linklayer, b4));

Thanks,
Dima
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html