netdev - [PATCH] net ixgbevf: ethtool statistics yields/misses fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 17 Dec 2015 15:16:32 +0000
From:	Tristan Colgate <tristan@...udflare.com>
To:	netdev@...r.kernel.org
Subject: [PATCH] net ixgbevf: ethtool statistics yields/misses fixes

ixgbevf over counts yields and does not actually count misses.
---
 drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
index d3e5f5b..ffdd8df 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
@@ -417,13 +417,13 @@ static void ixgbevf_get_ethtool_stats(struct
net_device *netdev,
        for (i = 0; i < adapter->num_rx_queues; i++) {
                rx_yields += adapter->rx_ring[i]->stats.yields;
                rx_cleaned += adapter->rx_ring[i]->stats.cleaned;
-               rx_yields += adapter->rx_ring[i]->stats.yields;
+               rx_missed += adapter->rx_ring[i]->stats.misses;
        }

        for (i = 0; i < adapter->num_tx_queues; i++) {
                tx_yields += adapter->tx_ring[i]->stats.yields;
                tx_cleaned += adapter->tx_ring[i]->stats.cleaned;
-               tx_yields += adapter->tx_ring[i]->stats.yields;
+               tx_missed += adapter->tx_ring[i]->stats.misses;
        }

        adapter->bp_rx_yields = rx_yields;
-- 
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html