netdev - Re: [PATCH iproute2] ip, route: fix minor compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5673CF5F.1060806@iogearbox.net>
Date:	Fri, 18 Dec 2015 10:18:23 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	Phil Sutter <phil@....cc>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip, route: fix minor compile warning

On 12/18/2015 02:12 AM, Stephen Hemminger wrote:
> On Mon, 14 Dec 2015 16:53:20 +0100
> Daniel Borkmann <daniel@...earbox.net> wrote:
>
>> On 12/14/2015 04:51 PM, Phil Sutter wrote:
>>> On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote:
>>>> Seems like gcc (4.8.3) doesn't catch this false positive, triggering
>>>> after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"):
>>>>
>>>>     iproute.c: In function 'print_route':
>>>>     iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>>        features &= ~RTAX_FEATURE_ECN;
>>>>                 ^
>>>>     iproute.c:575:10: note: 'val' was declared here
>>>>         __u32 val;
>>>>               ^
>>>> So just shut it up by initializing to 0.
>>>
>>> Hmm. Interestingly, my patch shouldn't have changed anything relevant
>>> for gcc's decision. OTOH, I don't see a warning using gcc-4.9.3.
>>
>> If I revert it, the warning is gone for me ;) perhaps some heuristic issue
>> with that gcc version.
>>
>> Cheers,
>> Daniel
>
> I don't see this warning on current master with gcc 4.9.2.

Well, in the commit message I wrote 4.8.3 ... but I don't mind if we drop it, sure.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html