netdev - Re: [PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56740C15.9080609@cogentembedded.com>
Date:	Fri, 18 Dec 2015 16:37:25 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	zyjzyj2000@...il.com, j.vosburgh@...il.com
Cc:	vfalico@...il.com, gospo@...ulusnetworks.com,
	netdev@...r.kernel.org, Boris.Shteinbock@...driver.com
Subject: Re: [PATCH 1/1] bonding: delay up state without speed and duplex in
 802.3ad mode

Hello.

On 12/18/2015 7:36 AM, zyjzyj2000@...il.com wrote:

> From: yzhu1 <yzhu1@...driver.com>
>
> In 802.3ad mode, the speed and duplex is needed. But in some NICs,
> there is a time span between NIC up state and getting speed and duplex.
> As such, sometimes a slave in 802.3ad mode is in up state without
> speed and duplex. This will make bonding in 802.3ad mode can not
> work well.
>
> To make bonding driver robust and compatible with more NICs, it is
> necessary to delay the up state without speed and duplex in 802.3ad
> mode.
>
> Signed-off-by: yzhu1 <yzhu1@...driver.com>
> ---
>   drivers/net/bonding/bond_main.c |   34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 9e0f8a7..a1d8708 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -419,6 +419,35 @@ const char *bond_slave_link_status(s8 link)
>   	}
>   }
>
> +/* This function is to check the speed and duplex of a NIC.
> + * Since the speed and duplex of a slave device are very
> + * important to the bonding in the 802.3ad mode. As such,
> + * it is necessary to check the speed and duplex of a slave
> + * device in 802.3ad mode.
> + *
> + * speed != SPEED_UNKNOWN and duplex == DUPLEX_FULL  :  1
> + *                                           others  :  0
> + */
> +static int __check_speed_duplex(struct net_device *netdev)
> +{
> +	struct ethtool_cmd ecmd;
> +	u32 slave_speed = SPEED_UNKNOWN;
> +	int res;
> +
> +	res = __ethtool_get_settings(netdev, &ecmd);
> +	if (res < 0)
> +		return 0;
> +
> +	slave_speed = ethtool_cmd_speed(&ecmd);
> +	if (slave_speed == 0 || slave_speed == ((__u32) -1))
> +		return 0;
> +
> +	if (DUPLEX_FULL != ecmd.duplex)

    Please place the immediate operand to the right of the != operator.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html