netdev - Re: [PATCH iproute2] lwtunnel: fix argument parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151217171631.4ea010c0@xeon-e3>
Date:	Thu, 17 Dec 2015 17:16:31 -0800
From:	Stephen Hemminger <shemming@...cade.com>
To:	Paolo Abeni <pabeni@...hat.com>
CC:	<netdev@...r.kernel.org>, Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH iproute2] lwtunnel: fix argument parsing

On Tue, 15 Dec 2015 12:18:04 +0100
Paolo Abeni <pabeni@...hat.com> wrote:

> Currently parse_encap_ip() does not update correctly argv/argc;
> if multiple lwtunnel arguments are provided, the parsing fails after
> the first one, i.e.
> 
>  ip route add 172.16.101.0/24 dev vxlan1 encap ip id 42 dst 192.168.255.1
> 
> fails with:
> 
>  Error: either "to" is duplicate, or "dst" is a garbage.
> 
> This commit addresses the issue, stepping to next argument at each iteration
> of the parsing loop.
> 
> Fixes: 1e5293056a02 ("lwtunnel: Add encapsulation support to ip route")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html