netdev - Re: [RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450496259.30687.12.camel@decadent.org.uk>
Date:	Sat, 19 Dec 2015 03:37:39 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	kan.liang@...el.com, netdev@...r.kernel.org, davem@...emloft.net,
	bwh@...nel.org
Cc:	jesse.brandeburg@...el.com, andi@...stfloor.org,
	f.fainelli@...il.com, alexander.duyck@...il.com,
	jeffrey.t.kirsher@...el.com, shannon.nelson@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	mitch.a.williams@...el.com, ogerlitz@...lanox.com,
	edumazet@...gle.com, jiri@...lanox.com, sfeldma@...il.com,
	gospo@...ulusnetworks.com, sasha.levin@...cle.com,
	dsahern@...il.com, tj@...nel.org, cascardo@...hat.com,
	corbet@....net
Subject: Re: [RFC 1/5] net/ethtool: introduce a new ioctl for per queue
 setting

On Sat, 2015-12-19 at 03:27 +0000, Ben Hutchings wrote:
> On Thu, 2015-12-17 at 06:51 +0000, kan.liang@...el.com wrote:
> > From: Kan Liang <kan.liang@...el.com>
> > 
> > Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting.
> > The following patches will enable some SUB_COMMANDs for per queue
> > setting.
> > 
> > Signed-off-by: Kan Liang <kan.liang@...el.com>
> > ---
> >  include/uapi/linux/ethtool.h | 18 ++++++++++++++++++
> >  net/core/ethtool.c           | 17 +++++++++++++++++
> >  2 files changed, 35 insertions(+)
> > 
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> > index cd16291..05bc92a 100644
> > --- a/include/uapi/linux/ethtool.h
> > +++ b/include/uapi/linux/ethtool.h
> > @@ -1144,6 +1144,22 @@ enum ethtool_sfeatures_retval_bits {
> >  #define ETHTOOL_F_WISH          (1 << ETHTOOL_F_WISH__BIT)
> >  #define ETHTOOL_F_COMPAT        (1 << ETHTOOL_F_COMPAT__BIT)
> >  
> > +#define MAX_QUEUE		4096
> > +#define MAX_QUEUE_MASK		(MAX_QUEUE / 64)
> > +
> > +/**
> > + * struct ethtool_per_queue_op - apply sub command to the queues in mask.
> > + * @cmd: ETHTOOL_PERQUEUE
> > + * @queue_mask: Mask the queues which sub command apply to
> > + * @sub_command: the sub command
> > + * @data: parameters of the command
[...]

You also need to make it clear that there's a complete command
structure following for each of the queues addressed, both for get and
set.  I.e. set does not apply the same settings to all queues.

Ben.

-- 
Ben Hutchings
Always try to do things in chronological order;
it's less confusing that way.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)