netdev - Re: [PATCH net-next] asix: silence log message from oversize packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151218.212514.1288582729750012735.davem@davemloft.net>
Date:	Fri, 18 Dec 2015 21:25:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	ben.hutchings@...ethink.co.uk, ivecera@...hat.com,
	linuxbrad@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] asix: silence log message from oversize packet

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Fri, 18 Dec 2015 16:15:03 -0800

> On Fri, 18 Dec 2015 16:08:53 -0500 (EST)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Stephen Hemminger <stephen@...workplumber.org>
>> Date: Thu, 17 Dec 2015 17:51:16 -0800
>> 
>> > Since it is possible for an external system to send oversize packets
>> > at anytime, it is best for driver not to print a message and spam
>> > the log (potential external DoS).
>> > 
>> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=109471
>> > 
>> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>> 
>> Seems reasonable, applied, thanks Stephen.
> 
> It doesn't fix the bug that is generating the oversize packet, that still needs
> to be root caused.

Remote systems can do this easily.  It's not a bug in the driver.

Say you decrease the MTU to 500 or whatever, nothing in the hardware
prevents reception of > 500 byte frames.

It's only a software limit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html