netdev - Re: [PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMiPYAFmKfF7_QJoOy++7y3FqNCWd7zzDz7xe5xdtvVXgQ@mail.gmail.com>
Date:	Mon, 21 Dec 2015 07:05:05 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	Saeed Mahameed <saeedm@...lanox.com>,
	Achiad Shochat <achiad@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Richard Cochran <richardcochran@...il.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Tal Alon <talal@...lanox.com>,
	Majd Dibbiny <majd@...lanox.com>,
	Saeed Mahameed <saeedm@....mellanox.co.il>
Subject: Re: [PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB

On Sun, Dec 20, 2015 at 11:46 PM, Saeed Mahameed wrote:
> From: Achiad Shochat <achiad@...lanox.com>
>
> If the SKB is cloned, or has an elevated users count, someone else
> can be looking at it at the same time.

>  drivers/net/ethernet/mellanox/mlx5/core/en.h      |    5 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c |    5 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_tx.c   |   73 ++++++++++++---------
>  3 files changed, 49 insertions(+), 34 deletions(-)

Guys, can this can be made in a manner which is lighter w.r.t data
path changes? lets make sure we do things (1) right and (2) efficient

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html