netdev - Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151221214222.5ee87383@xeon-e3>
Date:	Mon, 21 Dec 2015 21:42:22 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Lorenzo Colitti <lorenzo@...gle.com>
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	zenczykowski@...il.com
Subject: Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via
 SOCK_DESTROY.

On Thu, 17 Dec 2015 22:22:18 +0900
Lorenzo Colitti <lorenzo@...gle.com> wrote:

> diff --git a/misc/ss.c b/misc/ss.c
> index 0dab32c..be70c41 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -160,6 +160,9 @@ struct filter
>  	int states;
>  	int families;
>  	struct ssfilter *f;
> +	struct {
> +		__u8 kill:1;
> +	} action;
>  };
>  
>  stati

Please just make it a boolean or integer, not a structure wrapped around a bit field.
If you need to extend in the future then change it then. Please don't write code
based on speculative future additions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html