netdev - Re: [PATCH] sh_eth: fix 16-bit descriptor field access endianness too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151222.152401.1350968132902705224.davem@davemloft.net>
Date:	Tue, 22 Dec 2015 15:24:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: fix 16-bit descriptor field access endianness
 too

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 20 Dec 2015 01:48:04 +0300

> Commit 1299653affa4 ("sh_eth: fix descriptor access endianness") only
> addressed the 32-bit buffer address field byte-swapping  but the driver
> still accesses 16-bit frame/buffer length descriptor fields without the
> necessary byte-swapping -- which should affect the big-endian kernels.
> In order to be able to use {cpu|edmac}_to_{edmac|cpu}(), we need to declare
> the RX/TX descriptor word 1 as a 32-bit field and use shifts/masking to
> access the 16-bit subfields (which gets rid of the ugly #ifdef'ery too)...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied, thanks Sergei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html