netdev - Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151222.154552.1762036210080562354.davem@davemloft.net>
Date:	Tue, 22 Dec 2015 15:45:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gerlitz.or@...il.com
Cc:	hariprasad@...lsio.com, netdev@...r.kernel.org, leedom@...lsio.com,
	nirranjan@...lsio.com, john.r.fastabend@...el.com
Subject: Re: [PATCH net-next 3/5] cxgb4: add dcb info node in debugfs

From: Or Gerlitz <gerlitz.or@...il.com>
Date: Mon, 21 Dec 2015 09:33:22 +0200

> On Mon, Dec 21, 2015 at 9:16 AM, Hariprasad Shenai
> <hariprasad@...lsio.com> wrote:
>> Add new /sys/kernel/debug/cxgb4/*/dcb_info node to dump out
>> various Data Center Bridging information.
> 
> why? what's wrong with using the lldp tool for that purpose?

Agreed, and I don't like your explanation.

Even if you are using firmware managed DCB, the lldp tool should be
usable for querying.

People need to stop putting so much crap into debugfs, it's a serious
pet peeve of mine.

Every piece of driver unique interface crap you put into debugfs is a
_HARDSHIP_ for the user.  Because they have to learn a unique way to
do X in every driver that tries to export the same kind of
functionality.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html