netdev - Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5679C4B8.5010204@stressinduktion.org>
Date:	Tue, 22 Dec 2015 22:46:32 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:	eric.dumazet@...il.com
Subject: Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

On 21.12.2015 21:29, Florian Westphal wrote:
> tcp_md5_do_lookup requires a full socket, so once we extend
> _send_reset() to also accept timewait socket we would have to change
> 
> if (!sk && hash_location)
> 
> to something like
> 
> if ((!sk || !sk_fullsock(sk)) && hash_location) {
>   ...
> } else {
>   (sk && sk_fullsock(sk)) tcp_md5_do_lookup()
> }
> 
> Switch the two branches: check if we have a socket first, then
> fall back to a listener lookup if we saw a md5 option (hash_location).
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html