netdev - Re: Commit-8b63ec18 breaks setting PHY pad-skew settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151222101836.GA2373@lunn.ch>
Date:	Tue, 22 Dec 2015 11:18:36 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Roosen Henri <Henri.Roosen@...zinger.com>
Cc:	'Florian Fainelli' <f.fainelli@...il.com>,
	"david.daney@...ium.com" <david.daney@...ium.com>,
	"buytenh@...tstofly.org" <buytenh@...tstofly.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Commit-8b63ec18 breaks setting PHY pad-skew settings

> Unfortunately the patch is incomplete: it only fixes the issue for
> the KSZ9021. Please have a look at the funcion ksz9031_config_init()
> which has the the same (broken) search for the parent node.

Ah, sorry missed that. I was a bit blinkered, the issue was report for
KSZ9021 and i did not look further.

> As both the code for KSZ9021 as well as the code for KSZ9031 parse
> the same pad skew settings from the OF node (and to prevent
> incomplete fixes in the future), I think this code is a candidate to
> be cleaned up. Or is cooking up a similar patch for the KSZ9031 as
> for the KSZ9021 preferred?

Both would be best. We probably need a minimal fix we can get included
fast, and then having a cleanup patch merged during the next merge
window would be nice.

> Additionally, if this is a deprecated feature (like the commit
> states), then the devicetree binding documentation
> (Documentation/devicetree/bindings/net/micrel-ksz90x1.txt) should be
> updated. At least the deprecated example for autodetected PHY's
> should be corrected/removed.

I submitted a patch for that already.
https://www.mail-archive.com/netdev@vger.kernel.org/msg90932.html

It however does not seem to of made its way into net-next. If you
agree with it, please send an reviewed-by, or an Acked-by...

      Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html