netdev - Re: [E1000-devel] [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151223100940.661d997b@xeon-e3>
Date:	Wed, 23 Dec 2015 10:09:40 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
Cc:	"zyjzyj2000@...il.com" <zyjzyj2000@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Nelson, Shannon" <shannon.nelson@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Williams, Mitch A" <mitch.a.williams@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"Viswanathan, Ven \(Wind River\)" <venkat.viswanathan@...driver.com>,
	"Shteinbock, Boris \(Wind River\)" <boris.shteinbock@...driver.com>,
	"Bourg, Vincent \(Wind River\)" <vincent.bourg@...driver.com>
Subject: Re: [E1000-devel] [Intel-wired-lan] [PATCH 1/1] ixgbe: force to
 synchronize reporting	"link on" and getting speed and duplex

On Wed, 23 Dec 2015 15:59:24 +0000
"Tantilov, Emil S" <emil.s.tantilov@...el.com> wrote:

> >-----Original Message-----
> >From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...ts.osuosl.org] On
> >Behalf Of zyjzyj2000@...il.com
> >Sent: Tuesday, December 22, 2015 10:47 PM
> >To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny,
> >Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak, John; Williams, Mitch
> >A; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; e1000-
> >devel@...ts.sourceforge.net
> >Cc: Viswanathan, Ven (Wind River); Shteinbock, Boris (Wind River); Bourg,
> >Vincent (Wind River)
> >Subject: [Intel-wired-lan] [PATCH 1/1] ixgbe: force to synchronize
> >reporting "link on" and getting speed and duplex
> >
> >From: Zhu Yanjun <zyjzyj2000@...il.com>
> >
> >In X540 NIC, there is a time span between reporting "link on" and
> >getting the speed and duplex. To a bonding driver in 802.3ad mode,
> >this time span will make it not work well if the time span is big
> >enough. The big time span will make bonding driver change the state of
> >the slave device to up while the speed and duplex of the slave device
> >can not be gotten. Later the bonding driver will not have change to
> >get the speed and duplex of the slave device. The speed and duplex of
> >the slave device are important to a bonding driver in 802.3ad mode.
> >
> >To 82599_SFP NIC and other kinds of NICs, this problem does
> >not exist. As such, it is necessary for X540 to report"link on" when
> >the link speed is not IXGBE_LINK_SPEED_UNKNOWN.
> >
> >Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>
> >---
> > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   16 +++++++++++++++-
> > 1 file changed, 15 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> >b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> >index aed8d02..cb9d310 100644
> >--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> >+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> >@@ -6479,7 +6479,21 @@ static void ixgbe_watchdog_link_is_up(struct
> >ixgbe_adapter *adapter)
> > 	       (flow_rx ? "RX" :
> > 	       (flow_tx ? "TX" : "None"))));
> >
> >-	netif_carrier_on(netdev);
> >+	/*
> >+	 * In X540 NIC, there is a time span between reporting "link on"
> >+	 * and getting the speed and duplex. To a bonding driver in 802.3ad
> >+	 * mode, this time span will make it not work well if the time span
> >+	 * is big enough. To 82599_SFP NIC and other kinds of NICs, this
> >+	 * problem does not exist. As such, it is better for X540 to report
> >+	 * "link on" when the link speed is not IXGBE_LINK_SPEED_UNKNOWN.
> >+	 */
> >+	if ((hw->mac.type == ixgbe_mac_X540) &&
> >+	    (link_speed != IXGBE_LINK_SPEED_UNKNOWN)) {
> >+		netif_carrier_on(netdev);
> >+	} else {
> >+		netif_carrier_on(netdev);
> >+	}
> >+
> > 	ixgbe_check_vf_rate_limit(adapter);
> >
> > 	/* enable transmits */
> >--
> >1.7.9.5  
> 
> NAK
> 
> I have already submitted a patch that will address the issue with bonding reporting
> unknown speed (in /proc/bonding/bondX) after the link is established due to link flaps:
> http://patchwork.ozlabs.org/patch/552485/
> 
> The bonding driver gets the speed from ethtool and this is where the reporting needs
> to be fixed. The issue is that the bonding driver polls for netif_carrier_ok() at a 
> certain rate and as such will not be able to detect rapid link changes.

Kernel has netdev notifiers, these should really always be used rather than
polling. The polling stuff was added back in ancient kernel days when netdev
notifiers didn't work because most drivers were broken.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html