netdev - RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2F9547E@RTITMBSV03.realtek.com.tw>
Date:	Wed, 23 Dec 2015 09:20:25 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Oliver Neukum <oneukum@...e.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"peter@...ensteyn.nl" <peter@...ensteyn.nl>
Subject: RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

Oliver Neukum [mailto:oneukum@...e.de]
> Sent: Wednesday, December 23, 2015 4:20 PM
[...]
> No, step (2) does not exist. Calls to suspend() and [reset_]resume()
> always balance. Usually a driver shouldn't care about system suspend.
> The way the driver is currently coded will also fail for Port-Power Off.

It is different with Windows. The Windows would resume the device before
system suspend, if the system suspend follows the autosuspend.

Would this be a problem? After system suspend, the device may wake up
the system when receiving any packet, not only magic packet. The wake
events are different for system suspend and autosuspend. However, I
couldn't change the wake event, because the autosuspend occurs first,
and the suspend() is only called once.

Best Regards,
Hayes