netdev - Re: [PATCH net] geneve: initialize needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1450885176.4301.36.camel@redhat.com>
Date:	Wed, 23 Dec 2015 16:39:36 +0100
From:	Paolo Abeni <pabeni@...hat.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Pravin B Shelar <pshelar@...ira.com>,
	Jiri Benc <jbenc@...hat.com>, Jesse Gross <jesse@...ira.com>
Subject: Re: [PATCH net] geneve: initialize needed_headroom

On Wed, 2015-12-23 at 16:35 +0100, Hannes Frederic Sowa wrote:
> On 23.12.2015 16:21, Paolo Abeni wrote:
> > @@ -1187,6 +1187,14 @@ static int geneve_configure(struct net *net, struct net_device *dev,
> >  	if (t)
> >  		return -EBUSY;
> >  
> > +	/* make enough headroom for basic scenario */
> > +	encap_len = GENEVE_BASE_HLEN + ETH_HLEN;
> > +	if (remote->sa.sa_family == AF_INET)
> > +		encap_len += sizeof(struct iphdr);
> > +	else
> > +		encap_len += sizeof(struct ipv6hdr);
> > +	dev->needed_headroom = encap_len;
> > +
> 
> We are missing one time ETH_HLEN or hard_header_len of the lower_dev (if
> available) in here AFAIK.

You are right. Most probably performance numbers where good even with
the missing ETH_HLEN due to some rounding. I'll send a v2.

Paolo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html