netdev - Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2015 10:25:08 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Faisal Latif <faisal.latif@...el.com>
CC:	"dledford@...hat.com" <dledford@...hat.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"e1000-rdma@...ts.sourceforge.net" <e1000-rdma@...ts.sourceforge.net>
Subject: Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

On 12/24/2015 9:31 AM, Faisal Latif wrote:
> On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote:
>> On 12/22/2015 1:13 AM, Faisal Latif wrote:
>>> +
>>> +enum i40iw_memreg_type {
>>> +	IW_MEMREG_TYPE_MEM = 0x0000,
>>> +	IW_MEMREG_TYPE_QP = 0x0001,
>>> +	IW_MEMREG_TYPE_CQ = 0x0002,
>>> +	IW_MEMREG_TYPE_MW = 0x0003,
>>> +	IW_MEMREG_TYPE_FMR = 0x0004,
>>> +	IW_MEMREG_TYPE_FMEM = 0x0005,
>>> +};
>> Can't you re-use IB core values or derive that from the actual uverbs
>> command?
> I did not see anything which will have types that I needed.

what do you need? what is the role of this enum?

> It will be confusing otherwise.


> I will be reducing number of types from here though.

so why some of it can go? is that deal values which aren't used by the code

Or.

> Thanks
> Faisal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html