netdev - RE: [net-next 8/9] ixgbe: fix write to VLVFB in ixgbe_clear_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87618083B2453E4A8714035B62D67992504F2FF5@FMSMSX105.amr.corp.intel.com>
Date:	Fri, 25 Dec 2015 15:33:58 +0000
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	Alexander Duyck <alexander.duyck@...il.com>
Subject: RE: [net-next 8/9] ixgbe: fix write to VLVFB in
 ixgbe_clear_vf_vlans()

>-----Original Message-----
>From: Kirsher, Jeffrey T
>Sent: Thursday, December 24, 2015 9:30 PM
>To: davem@...emloft.net
>Cc: Tantilov, Emil S; netdev@...r.kernel.org; nhorman@...hat.com;
>sassmann@...hat.com; jogreene@...hat.com; Kirsher, Jeffrey T
>Subject: [net-next 8/9] ixgbe: fix write to VLVFB in ixgbe_clear_vf_vlans()
>
>From: Emil Tantilov <emil.s.tantilov@...el.com>
>
>Fix the write to the VLVFB register in ixgbe_clear_vf_vlans() where
>word is the actual offset of the register and not the index for the
>IXGBE_VLVFB macro.
>
>This was causing PCI AER errors on my system.
>
>Fixes: 4c7f35f679f592804736f9303051257de2c9f021
>("ixgbe: Clean stale VLANs when changing port VLAN or resetting")
>
>Signed-off-by: Emil Tantilov <emil.s.tantilov@...el.com>
>Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
>Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>index eeff3d0..fd918da 100644
>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>@@ -640,7 +640,7 @@ update_vlvf:
> 		IXGBE_WRITE_REG(hw, IXGBE_VLVF(i), 0);
> update_vlvfb:
> 		/* clear pool bits */
>-		IXGBE_WRITE_REG(hw, IXGBE_VLVFB(word), vlvfb);
>+		IXGBE_WRITE_REG(hw, word, vlvfb);
> 	}
> }
>
>--
>2.5.0

Alex submitted another patch for this function that should've been
used instead as it also resolves an issue with the mask.

Thanks,
Emil 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html