netdev - Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Dec 2015 12:28:25 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next 0/3] Ethtool support for phy stats

On December 28, 2015 12:02:13 PM PST, David Miller <davem@...emloft.net> wrote:
>From: Florian Fainelli <f.fainelli@...il.com>
>Date: Mon, 28 Dec 2015 09:27:25 -0800
>
>> On December 28, 2015 12:58:25 AM PST, Andrew Lunn <andrew@...n.ch>
>wrote:
>>>On Mon, Dec 28, 2015 at 12:44:27AM -0500, David Miller wrote:
>>>> From: David Miller <davem@...emloft.net>
>>>> Date: Mon, 28 Dec 2015 00:32:43 -0500 (EST)
>>>> 
>>>> > From: Andrew Lunn <andrew@...n.ch>
>>>> > Date: Sun, 27 Dec 2015 12:58:25 +0100
>>>> > 
>>>> >> This patchset add ethtool support for reading statistics from
>the
>>>PHY.
>>>> >> The Marvell and Micrel Phys are then extended to report receiver
>>>> >> packet errors and idle errors.
>>>> >> 
>>>> >> v2:
>>>> >>   Fix linking when phylib is not enabled.
>>>> > 
>>>> > Series applied, thanks Andrew.
>>>> 
>>>> I have to revert this.
>>>> 
>>>> You can't call into PHY library code from net/core/ethtool.c,
>>>> because PHY lib can be modular.
>>>
>>>O.K.
>>>
>>>How about we change PHYLIB from a tristate to a bool?
>> 
>> Could we make this in a two layer design instead? Core ethtool
>changes call into getter functions which are implemented by the netdev
>driver, if the netdev driver happens to use PHYLIB, calls into the
>PHYLIB helpers with its phydev? That would also allow a network driver
>already supporting PHY stats to report them through your new interface.
>
>Or just put the helpers in net/core/ethtool.c

That would work, Intel drivers could benefit from that interface if it is not too phydev centric. We would have to know if the netdev uses phylib, but that's already the case for things like WoL and MII ioctl.


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html