netdev - Re: [PATCH] unix: properly account for FDs passed over unix sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56829AB3.9000607@stressinduktion.org>
Date:	Tue, 29 Dec 2015 15:37:39 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Willy Tarreau <w@....eu>, "David S. Miller" <davem@...emloft.net>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Eric Dumazet <edumazet@...gle.com>, socketpair@...il.com
Subject: Re: [PATCH] unix: properly account for FDs passed over unix sockets

On 28.12.2015 15:14, Willy Tarreau wrote:
> @@ -1528,10 +1546,8 @@ static int unix_attach_fds(struct scm_cookie *scm, struct sk_buff *skb)
>   	if (!UNIXCB(skb).fp)
>   		return -ENOMEM;
>
> -	if (unix_sock_count) {
> -		for (i = scm->fp->count - 1; i >= 0; i--)
> -			unix_inflight(scm->fp->fp[i]);
> -	}
> +	for (i = scm->fp->count - 1; i >= 0; i--)
> +		unix_inflight(scm->fp->fp[i]);
>   	return max_level;

You seem to be able to remove the unix_sock_count variable altogether now.

Bye,
Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html