netdev - Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqt6zacF-n0pRxU0=pq79rKCt1Y-08taaZxBrFdre4JMH6tbQ@mail.gmail.com>
Date:	Tue, 29 Dec 2015 23:46:43 +0530
From:	Souptick Joarder <jrdr.linux@...il.com>
To:	Brent Taylor <motobud@...il.com>
Cc:	netdev@...r.kernel.org, ath6kl@...ts.infradead.org,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kalle Valo <kvalo@....qualcomm.com>
Subject: Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

Brent,

On Tue, Dec 22, 2015 at 2:42 PM, Kalle Valo <kvalo@....qualcomm.com> wrote:
> Souptick Joarder <jrdr.linux@...il.com> writes:
>
>> Hi Brent,
>>
>> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <motobud@...il.com> wrote:
>>> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.linux@...il.com> wrote:
>>>> Hi Brent,
>>>>
>>>> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <motobud@...il.com> wrote:
>>>>
>>>>> --- a/drivers/net/wireless/ath/ath6kl/init.c
>>>>> +++ b/drivers/net/wireless/ath/ath6kl/init.c
>>>>> @@ -673,10 +673,15 @@ static int ath6kl_get_fw(struct ath6kl *ar, const char *filename,
>>>>>                 return ret;
>>>>>
>>>>>         *fw_len = fw_entry->size;
>>>>> -       *fw = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL);
>>>>> +   if (&ar->fw == fw)
>>>>> +               *fw = vmalloc(fw_entry->size);
>>>>> +   else
>>>>> +               *fw = kmalloc(fw_entry->size, GFP_KERNEL)
>>>>
>>>>           Why vmalloc and kmalloc both are required? can't use either
>>>> vmalloc or kmalloc?
>>>
>>> My original problem was that kmemdup (which uses kmalloc) could not
>>> allocate enough memory
>>
>> If kmemdump ( which uses kmalloc) could not allocate memory then
>> using kmalloc again can lead to same problem.
>> I guess it will be correct to use
>>             *fw = vmalloc(fw_entry->size);
>> Correct me if i am wrong.
>
> That sounds best. But remember take into account DMA requirements, IIRC
> you cannot DMA from vmalloc memory on all platforms.

Is it possible to modify the patch as per feedback from Kalle.

>
> --
> Kalle Valo

-Souptick
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html