netdev - Re: Linux 4.4-rc4 regression, bisected to "net: fix sock_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1451483700.8255.18.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 30 Dec 2015 08:55:00 -0500
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nicolai Stange <nicstange@...il.com>
Cc:	Andy Lutomirski <luto@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: Linux 4.4-rc4 regression, bisected to "net: fix
 sock_wake_async() rcu protection"

On Wed, 2015-12-30 at 12:32 +0100, Nicolai Stange wrote:
> Andy Lutomirski <luto@...nel.org> writes:
> 
> > On recent v4.4-rc releases, I can't run emacs.  No, really, running
> > "emacs" in a GNOME 3 session makes gnome-shell think that emacs is
> > running, but no window is drawn, and the overall system UI is a bit
> > weird when the invisible emacs window is focused.
> >
> > This is 100% reproducible.
> >
> > There might be other symptoms involving gdb malfunctioning, but those
> > are, at best, sporadic.  The emacs failure is entirely reliable.  I
> > have no idea what the underlying failure mode is, but failure to wake
> > a socket waiter seems plausible,  I also have no idea why oocalc,
> > gimp, vim, gedit, firefox, etc aren't affected.
> >
> > A somewhat unorthodox "git bisect" run blames:
> >
> > commit ceb5d58b217098a657f3850b7a2640f995032e62
> > Author: Eric Dumazet <edumazet@...gle.com>
> > Date:   Sun Nov 29 20:03:11 2015 -0800
> >
> >     net: fix sock_wake_async() rcu protection
> >
> > I've confirmed that v4.4-rc7 with that patch reverted works fine.
> >
> > Since the offending commit was apparently a security fix, simply
> > reverting it might not be the best idea.
> 
> Please have a look at https://lkml.kernel.org/g/87ege73bma.fsf@gmail.com
> 
> I ran into the same issue and this one fixes it for me.

Right, and the ozlabs pointers for this were :

v1:
https://patchwork.ozlabs.org/patch/561194/

v2:
https://patchwork.ozlabs.org/patch/561553/

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html