netdev - Re: [PATCH 1/1] ixgbe: synchronize link_up and link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1451540268.3348.108.camel@intel.com>
Date:	Wed, 30 Dec 2015 21:37:48 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	zyjzyj2000@...il.com, jesse.brandeburg@...el.com,
	shannon.nelson@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, bruce.w.allan@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net, mark.d.rustad@...el.com
Cc:	venkat.viswanathan@...driver.com, Boris.Shteinbock@...driver.com,
	Vincent.Bourg@...driver.com
Subject: Re: [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a
 slave interface

On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2000@...il.com wrote:
> From: Zhu Yanjun <yanjun.zhu@...driver.com>
> 
> According to the suggestions from Rustad, Mark D, to all the slave 
> interfaces, the link_speed and link_up should be synchronized since
> the time span between link_up and link_speed will make some virtual
> NICs not work well, such as a bonding driver in 802.3ad mode.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...driver.com>
> ---

Since this is version 5 of your original patch, you should be putting
the change log of this patch here, so that we can follow how you got to
this point.  This helpful for the reviewers (and me, the maintainer).
 For example:
v2: dropped the "else" case of "if" statement, based on feedback from
    Jeff Kirsher
v3: changed the if statement to simply return when the link speed is
    unknown on X540 parts based on feedback from Emil Tantilov
v4: updated code comment and if statement to test for IFF_SLAVE flag
V5: simplified code comment and if statement to only test for IFF_SLAVE
    flag and unknown link speed.

Of course, you can expand on what I have above, I just did a quick
summary of the changes as an example of a change log. 

>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++++
>  1 file changed, 5 insertions(+)

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)