lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Jan 2016 02:14:46 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net>, libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Kalle Valo <kvalo@...eaurora.org> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker() Hello On 1/2/2016 12:33 AM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Fri, 1 Jan 2016 22:27:20 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "err" will not be checked once more > after it was determined that a function call failed. > Use the identifier "report_failure" instead of the label "err". Why? The code was smart enough and you're making it uglier that it needs to be. > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists