netdev - Re: [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160103150425.79f05a52@xeon-e3>
Date:	Sun, 3 Jan 2016 15:04:25 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long
 comments

On Sun, 3 Jan 2016 19:44:29 +0100
Andreas Henriksson <andreas@...al.se> wrote:

> Hello Stephen Hemminger.
> 
> Please beware that this has been compile-tested only.
> Submitting it like this was what I was trying to avoid
> by just throwing in a FIXME comment in the initial submission.
> Sorry in advance if I managed to screw something up, but
> hopefully I didn't...
> 
> Regards,
> Andreas Henriksson
> 

All this seems like overkill. The file format for arpd is very simple:
ifindex, IPv4, MAC
and really should never be too long. If it is the input is garbage and the
whole input should just be rejected, logged, and arpd should exit.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html