netdev - Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568ACF80.5070105@gmail.com>
Date:	Mon, 04 Jan 2016 12:01:04 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device
 for phys

On 04/01/16 09:36, Andrew Lunn wrote:
> We will soon support devices other than phys on the mdio bus. Look at
> a child's compatibility string to determine if it is a phy, before
> registering a phy device.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

[snip]

> +	if (of_get_phy_id(child, &phy_id) != -EINVAL)
> +		return true;
> +
> +	if (of_device_is_compatible(child, "ethernet-phy-ieee802.3-c45"))
> +		return true;

Is there a particular reason not to check for
"ethernet-phy-ieee802.3-c22 here?

> +
> +	if (!of_find_property(child, "compatible", NULL))
> +		return true;

That seems reasonable, we should probably make the compatible string for
PHY Device Tree nodes not an optional property anymore though, but
that's for a separate change and topic.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html