netdev - Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Jan 2016 14:05:35 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Mason <slash.tmp@...e.fr>
CC:	netdev@...r.kernel.org, Mans Rullgard <mans@...sr.com>
Subject: Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock
 delay via phy mode

On 04/01/16 13:17, Martin Blumenstingl wrote:
> On Sun, Dec 27, 2015 at 9:22 PM, Mason <slash.tmp@...e.fr> wrote:
>> On 27/12/2015 04:28, Florian Fainelli wrote:
>>
>>> Le 25/12/2015 16:27, Martin Blumenstingl wrote:
>>>
>>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
>>>> index f566b6e..0b262a2 100644
>>>> --- a/drivers/net/phy/at803x.c
>>>> +++ b/drivers/net/phy/at803x.c
>>>> @@ -36,8 +36,10 @@
>>>>  #define AT803X_INSR                         0x0013
>>>>  #define AT803X_DEBUG_ADDR                   0x1D
>>>>  #define AT803X_DEBUG_DATA                   0x1E
>>>> -#define AT803X_DEBUG_SYSTEM_MODE_CTRL               0x05
>>>> -#define AT803X_DEBUG_RGMII_TX_CLK_DLY               BIT(8)
>>>> +#define AT803X_DEBUG_REG_0                  0x00
>>>
>>> Seems like the previous register name might have been clearer that the
>>> new name you suggest here, did that come from a different GPL tarball or
>>> documentation?
>>
>> http://www.redeszone.net/app/uploads/2014/04/AR8035.pdf
>>
>> According to the 8035 data sheet, the debug register at offset 0
>> is just "Debug register 0". In fact, the only non-reserved bit is
>> "rgmii rx clock delay enable/disable"
> Thanks for verifying this.
> 
> @Florian: Did you already have time to look at my comments? I know
> it's vacation season, but I'd like to fix all remaining issues soon.

That answers my question, there were still two other things that needed
to be addressed:

- the bool parameter to the enable RX/TX delay is currently only set to
"true"
- the mutex does not need to be acquired

Could you respin this patch series with this addressed? Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html