netdev - Re: [Linux-v4.4-LTS] ppp: Backport of rtnetlink device handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160104125528.GB1267@alphalink.fr>
Date:	Mon, 4 Jan 2016 13:55:28 +0100
From:	Guillaume Nault <g.nault@...halink.fr>
To:	Sedat Dilek <sedat.dilek@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [Linux-v4.4-LTS] ppp: Backport of rtnetlink device handling

On Mon, Jan 04, 2016 at 08:47:30AM +0100, Sedat Dilek wrote:
> Hi Guillaume,
> 
> which patches do I need to backport "ppp: rtnetlink device handling"
> to Linux v4.4 which will be a LongTerm-Supported (LTS) Linux-kernel
> [0]?
> 
Quite frankly, backporting this series doesn't look like a good idea.
It only provides a new ABI for creating ppp devices and your control
plane most likely hasn't been updated to use it. So it won't bring any
benefit.

> I tried [1] and [2] on top of recent net-next Git tree which will be
> in Linux v4.5.
> Currently, your patches are not included in net-next.git#master.
> 
Indeed, and that's why no control plane should rely on them (yet).

> In the thread "[net-next] ppp: rtnetlink device handling" [4] you
> explained the benefits and use-case etc.
> 
> Checking with git-log shows me these commits...
> 
> $ git log --oneline --no-merges v4.4-rc8.. drivers/net/ppp net/l2tp
> 19e8c5713e78 l2tp: rely on ppp layer for skb scrubbing
> 645eee4eba45 ppp: implement rtnetlink device handling
> 3a9bce0ae138 ppp: define reusable device creation functions
> 69d9728d00c7 ppp: declare ppp devices as enumerated interfaces
> 94dbffe16eb1 ppp: define "ppp" device type
> 681b4d88ad8e pppox: use standard module auto-loading feature
> a8acce6aa584 ppp: remove PPPOX_ZOMBIE socket state
> 8734e485fed5 ppp: don't set sk_state to PPPOX_ZOMBIE in pppoe_disc_rcv()
> 
> ...is that sufficient for a backport?
> 
Applying the series directly on v4.4-rc8 should work (with a few
conflicts, but other patches are unrelated). But still, you probably
don't want to maintain backports unless strictly required. BTW, this
one has no chance to hit any -stable tree anyway.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html