netdev - Re: [RFC PATCH 02/12] net: sched: free per cpu bstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1451928758.8255.76.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 04 Jan 2016 09:32:38 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	John Fastabend <john.fastabend@...il.com>, jhs@...atatu.com,
	aduyck@...antis.com, brouer@...hat.com, davem@...emloft.net,
	john.r.fastabend@...el.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH 02/12] net: sched: free per cpu bstats

On Mon, 2016-01-04 at 16:21 +0100, Daniel Borkmann wrote:
> On 12/30/2015 06:51 PM, John Fastabend wrote:
> > When a qdisc is using per cpu stats only the bstats are being
> > freed. This also free's the qstats.
> >
> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> 
> Seems like a bug fix, current code seems to free this only in error
> path in qdisc_create(). Should this go to -net as an individual one?

Absolutely, this is needed in -net as ingress qdisc uses this stuff
already.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html