netdev - Re: [PATCH net-next] soreuseport: change consume_skb to kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452022480.8255.118.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 05 Jan 2016 11:34:40 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Craig Gallek <kraigatgoog@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb
 in error case

On Tue, 2016-01-05 at 14:12 -0500, Craig Gallek wrote:

> OK, I can buy that an skb should be piped through udp4|6_lib_lookup2,
> but I don't think it's safe to remove the skb NULL check in
> reuseport_select_sock.  There's at least one path (udp_diag.c:
> udp_dump_one) which does a lookup without an skb.  I'll start with
> your patch in a separate thread and we can discuss outside the context
> of the kfree_skb change.

Well, udp_dump_one() is broken vs SO_REUSEPORT. Fortunately iproute2
does not use it (yet)

We need to to get the socket designated by req->id.idiag_cookie,
ie ignoring reusport hash or BPF completely.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html