netdev - Re: [PATCH net-next v1 1/2] tipc: move netlink policies to netlink.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160105.164749.1356932343853770417.davem@davemloft.net>
Date:	Tue, 05 Jan 2016 16:47:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	richard.alpe@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next v1 1/2] tipc: move netlink policies to
 netlink.h

From: Richard Alpe <richard.alpe@...csson.com>
Date: Tue, 5 Jan 2016 10:56:16 +0100

> Make the c files less cluttered and enable netlink attributes to be
> shared between files. This will prove useful in a future patch where a
> node message will contain a nested network.
> 
> Signed-off-by: Richard Alpe <richard.alpe@...csson.com>
> Acked-by: Jon Maloy <jon.maloy@...csson.com>

netlink.h is included by more than one file, which means the tables
(might) be instantiated multiple times.

I'd really recommend not putting such tables in a header file that
is used in this way.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html