netdev - Re: [PATCH net-next] udp_diag: fix udp_dump_one() vs SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452032534.8255.137.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 05 Jan 2016 14:22:14 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Craig Gallek <kraigatgoog@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] udp_diag: fix udp_dump_one() vs SO_REUSEPORT

On Tue, 2016-01-05 at 14:08 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> udp_dump_one() uses __udp4_lib_lookup() & __udp6_lib_lookup()
> which cannot properly handle the provided cookie when SO_REUSEPORT
> is used, as many sockets share the same 4-tuple
> 
> Instead, let's use the provided 64bit cookie to uniquely identify
> the socket.
> 
> This will allow us to remove a check against skb being NULL in
> reuseport_select_sock(), as we no longer share __udp4_lib_lookup() &
> __udp6_lib_lookup() with packet processing path.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

I'll send a v2, removing the EXPORT_SYMBOL(__udp4_lib_lookup) and add a
static qualifier. (Same for v6)

Also, INET_UDP_DIAG can depends on INET_DIAG instead of "depends on
INET_DIAG && (IPV6 || IPV6=n)"



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html