netdev - Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160104.223916.1424025684080316788.davem@davemloft.net>
Date:	Mon, 04 Jan 2016 22:39:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, alexandre.torgue@...com,
	fabrice.gasnier@...com
Subject: Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc
 management

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Mon, 4 Jan 2016 14:06:54 +0100

> @@ -334,12 +334,11 @@ struct stmmac_desc_ops {
>  
>  	/* Invoked by the xmit function to prepare the tx descriptor */
>  	void (*prepare_tx_desc) (struct dma_desc *p, int is_fs, int len,
> -				 int csum_flag, int mode);
> +				 int csum_flag, int mode, int tx_own,
> +				 bool ls_ic);

I don't understand how you can get the type right and use 'bool' for
'ls_ic' but then incorrectly use an int for 'tx_own'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html