netdev - Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568B8574.7070304@st.com>
Date:	Tue, 5 Jan 2016 09:57:24 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <alexandre.torgue@...com>,
	<fabrice.gasnier@...com>
Subject: Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

On 1/5/2016 4:39 AM, David Miller wrote:
> From: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Date: Mon, 4 Jan 2016 14:06:54 +0100
>
>> @@ -334,12 +334,11 @@ struct stmmac_desc_ops {
>>
>>   	/* Invoked by the xmit function to prepare the tx descriptor */
>>   	void (*prepare_tx_desc) (struct dma_desc *p, int is_fs, int len,
>> -				 int csum_flag, int mode);
>> +				 int csum_flag, int mode, int tx_own,
>> +				 bool ls_ic);
>
> I don't understand how you can get the type right and use 'bool' for
> 'ls_ic' but then incorrectly use an int for 'tx_own'.
>

sure I will fix it too.

thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html