netdev - Re: [RFC PATCH net-next 11/24] phy: Add an mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568B2208.3060502@gmail.com>
Date:	Mon, 04 Jan 2016 17:53:12 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 11/24] phy: Add an mdio_device structure

On 04/01/16 09:36, Andrew Lunn wrote:
> Not all devices attached to an MDIO bus are phys. So add an
> mdio_device structure to represent the generic parts of an mdio
> device, and place this structure into the phy_device.

This looks good to me, I am just wondering if it would make sense to
introduce another patch, prior to this one which does something like:

- expose phydev_addr(phydev) to encapsulate the phy device's addr member
and convert all drivers listed here to that helper, do the same thing
with phydev_bus(phydev) to get the mii_bus of a given PHY device

- have a subsequent patch which relocates phydev->{addr,bus} to the
common MDIO device structure?

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html