netdev - Re: [RFC PATCH net-next 14/24] phy_device: Move phy attributes into phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568B2318.1050103@gmail.com>
Date:	Mon, 04 Jan 2016 17:57:44 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 14/24] phy_device: Move phy attributes into
 phy_device

On 04/01/16 09:36, Andrew Lunn wrote:
> The mdio_bus exports three attributes. However these are all phy
> attributes, not generic mdio attributes. So move the attributes into
> the phy device code.

It could help to mention why just in case you have to respin that patch
series:

- PHY ID is the unique 32-bits identifier for a MDIO device implementing
standard MII registers MII_PHYSID1/2, which is not guaranteed to be the
case for non-standard compliant devices (e.g: Ethernet switches)

- PHY interface describes the data-path of the PHY/MDIO device, which is
not strictly a PHY thing, but is required and needed for PHY devices to
function, a MDIO device could be a control device exclusively

- PHY has fixups describes what the PHY driver may have done, so
completely PHY specific

> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html