netdev - Re: [PATCH] net: sched: fix missing free per cpu on qstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452049669.8255.157.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 05 Jan 2016 19:07:49 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	John Fastabend <john.fastabend@...il.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH] net: sched: fix missing free per cpu on qstats

On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote:
> On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
> >> When a qdisc is using per cpu stats (currently just the ingress
> >> qdisc) only the bstats are being freed. This also free's the qstats.
> >>
> >> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> >> ---
> >
> > Acked-by: Eric Dumazet <edumazet@...gle.com>
> >
> > David, please add the following tag to ease backports to stable kernels:
> >
> > Fixes: 22e0f8b9322cb ("net: sched: make bstats per cpu and estimator RCU safe")
> >
> 
> Not a big deal at all but... doesn't that fix commit b0ab6f92752b9f9d8
> instead of 22e0f8b9322cb?

Hmmm... you may be right. Both were added in 3.18.

My search was based on commit adding qdisc_is_percpu_stats()



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html